[ISSUE-#4567] Refactor nacos-client Load Logging Configuration code. #4572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horizonzy
requested changes
Dec 25, 2020
| public static void loadConfiguration(AbstractNacosLogging logging) { | ||
| try { | ||
| if (logging != null) { | ||
| logging.loadConfiguration(); |
…e default Logging Load Configuration.
horizonzy
reviewed
Dec 25, 2020
| try { | ||
| logging.loadConfiguration(); | ||
| } catch (Exception e) { | ||
| LOGGER.warn("Customize the {} load Configuration fail, message: {}", logging.getClass().getName(), e.getMessage()); |
There was a problem hiding this comment.
LOGGER.warn("Customize the {} load configuration fail, use default log configuration. Message: {}", logging.getClass().getName(), e.getMessage());
| */ | ||
| public void loadConfiguration() { | ||
| try { | ||
| nacosLogging.loadConfiguration(); |
There was a problem hiding this comment.
这里是单例模式+策略模式的实现，对外其实只暴露了这一个方法，内部具体是logback还是log4j2是在初始化的时候决定的。
暂时没有开放完全拓展，主要是两个考虑， 一方面是nacos的日志主要是给运维人员排查用，不希望业务人员随意的改动nacos日志输出的级别和内容，另一方面日志框架其实并不太多，不会频繁扩展，适配起来难度不高。
将来如果需要完全拓展， 初始化加载的时候用个SPI就可以了。
KomachiSion
approved these changes
Dec 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
fix: #4567
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.